Skip to content

Update UMF and add fetching CUDA #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update UMF and add fetching CUDA #2252

merged 1 commit into from
Nov 15, 2024

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Oct 28, 2024 •
edited
Loading

It contains:
"Fix fetching L0 and CUDA headers and add UMF_CUDA_INCLUDE_DIR"
oneapi-src/unified-memory-framework#832

@ldorau ldorau requested a review from a team as a code owner October 28, 2024 09:47
@github-actions github-actions bot added the common Changes or additions to common utilities label Oct 28, 2024
@ldorau ldorau force-pushed the Update_UMF_to_28.10.2024_Merge_pull_request_#832 branch from 3fc007a to 9428bae Compare October 29, 2024 08:15
@ldorau ldorau changed the title Update UMF to 28.10.2024 (Merge pull request #832) Update UMF and add fetching CUDA Oct 29, 2024
@ldorau
Copy link
Contributor Author

ldorau commented Oct 29, 2024

@pbalcer @bratpiorka please review

PatKamin
PatKamin reviewed Oct 29, 2024
View reviewed changes
PatKamin
PatKamin reviewed Oct 29, 2024
View reviewed changes
@ldorau ldorau requested a review from PatKamin October 29, 2024 21:24
@ldorau ldorau force-pushed the Update_UMF_to_28.10.2024_Merge_pull_request_#832 branch from 9428bae to 5c93d72 Compare October 29, 2024 21:25
@ldorau ldorau force-pushed the Update_UMF_to_28.10.2024_Merge_pull_request_#832 branch from 5c93d72 to ce0c110 Compare October 30, 2024 10:37
@ldorau
Copy link
Contributor Author

ldorau commented Oct 30, 2024

@bratpiorka @pbalcer re-review please

@lukaszstolarczuk
Copy link
Contributor

lukaszstolarczuk commented Oct 31, 2024

random CI failure or we broke something in L0 provider...? 😉

@bratpiorka
Copy link
Contributor

bratpiorka commented Oct 31, 2024

random CI failure or we broke something in L0 provider...? 😉

only 2 tests fails:
[ FAILED ] urEnqueueEventsWaitMultiDeviceMTTest.EnqueueWaitSingleQueueMultiOps/MultiThread
[ FAILED ] urEnqueueKernelLaunchIncrementMultiDeviceMultiThreadTest.Success/NoUseEventsNoQueuePerThread

@ldorau
Copy link
Contributor Author

ldorau commented Nov 5, 2024

@bratpiorka @lukaszstolarczuk All tests passed: 4 skipped and 73 successful checks

lukaszstolarczuk
lukaszstolarczuk approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Nov 7, 2024
Closed
@lukaszstolarczuk
Copy link
Contributor

lukaszstolarczuk commented Nov 7, 2024

ref. intel/llvm#16007
on intel/llvm testing two e2e tests failed:

https://github.com/intel/llvm/actions/runs/11721056696/job/32648261452?pr=16007#step:22:4415

@bratpiorka
Copy link
Contributor

bratpiorka commented Nov 8, 2024

@ldorau please rebase

@ldorau ldorau force-pushed the Update_UMF_to_28.10.2024_Merge_pull_request_#832 branch from ce0c110 to 1b609b4 Compare November 8, 2024 10:56
@ldorau
Copy link
Contributor Author

ldorau commented Nov 8, 2024

@ldorau please rebase

@bratpiorka Done

@lukaszstolarczuk
Copy link
Contributor

lukaszstolarczuk commented Nov 12, 2024

ref. intel/llvm#16007 intel/llvm testing

I used the new, rebased version and the testing passed on Friday - LGTM 👍

@pbalcer pbalcer merged commit 99d8f4f into oneapi-src:main Nov 15, 2024
84 checks passed
@pbalcer pbalcer mentioned this pull request Nov 18, 2024
Closed
@ldorau ldorau deleted the Update_UMF_to_28.10.2024_Merge_pull_request_#832 branch December 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@PatKamin PatKamin PatKamin approved these changes

Assignees

No one assigned

Labels

common Changes or additions to common utilities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ldorau @lukaszstolarczuk @bratpiorka @PatKamin @pbalcer